Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Reuse existing build for WPT runs #32047

Open
nicoburns opened this issue Apr 11, 2024 · 1 comment
Open

CI: Reuse existing build for WPT runs #32047

nicoburns opened this issue Apr 11, 2024 · 1 comment
Labels
B-feature-tracking This issue tracks a particular high-level feature

Comments

@nicoburns
Copy link
Contributor

Background

Currently WPT tasks run on CI will all individually rebuild servo even though they run after a build task which will have already built a Servo binary for that commit. This effectively doubles the amount of time spent compiling Servo, and as this is typically slower than running the tests themselves has a significant affect on the overall amount of time it takes to run WPT checks on CI.

Proposal

  • Save the binary from "build" runs as a Github Actions artefact.
  • When running WPT tasks, search for artefacts matching the current commit. And if one exists use it instead of rebuilding

Notes

@nicoburns nicoburns added B-feature-tracking This issue tracks a particular high-level feature C-untriaged New issues that haven't been triaged yet labels Apr 11, 2024
@sagudev sagudev removed the C-untriaged New issues that haven't been triaged yet label Apr 11, 2024
@sagudev
Copy link
Member

sagudev commented Apr 11, 2024

Artifacts are already made in build job all the time no matter if WPT is requested or not. So we only need to "skip" build task if it is already running (there is concurrency), but we need to make sure it has the same profile as we are now trying to run.

Although I am not sure when this would be useful as I usually do mach try before or immediately after pushing commit (so way before any build artifact is actually available).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-feature-tracking This issue tracks a particular high-level feature
Projects
None yet
Development

No branches or pull requests

2 participants