Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webgpu runs script callbacks twice #32172

Open
sagudev opened this issue Apr 29, 2024 · 2 comments
Open

Webgpu runs script callbacks twice #32172

sagudev opened this issue Apr 29, 2024 · 2 comments
Labels
A-content/webgpu The WebGPU implementation.

Comments

@sagudev
Copy link
Member

sagudev commented Apr 29, 2024 •
edited

Ipc-channel created from response_async should only send one message back, but wgpu runs callback also on failures:
https://github.com/gfx-rs/wgpu/blob/8597367d5566de321f2ce1e1bd58570cdc9bb930/wgpu-core/src/device/global.rs#L2391
So we send one msg from match case of BufferMapAsync and one from it's callback.
@sagudev sagudev added the A-content/webgpu The WebGPU implementation. label Apr 29, 2024
@sagudev sagudev mentioned this issue Apr 29, 2024
Merged
3 tasks
@gterzian
Copy link
Member

Solved by the PR?

@sagudev
Copy link
Member Author

sagudev commented May 13, 2024 •
edited

Solved by the PR?

No, this still something that needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/webgpu The WebGPU implementation.
Projects
WebGPU
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gterzian @sagudev