Fix percentage height calculation, absolute containing block height calculations. #6903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton |
glennw
force-pushed
the
fix-height-again
branch
from
3bcec59
to
b01591a
Compare
| } | ||
| } | ||
|
|
||
| fn get_explict_block_size(&self, containing_block_size: Option<Au>) -> Option<Au> { |
There was a problem hiding this comment.
typo: explict -> explicit
Also I'd remove the get from this method and the one above.
…alculations. It's not possible to correctly determine during the css cascade whether the container height is explicitly specified. Additionally, the spec https://drafts.csswg.org/css2/visudet.html#the-height-property says this should affect the *used* height, rather than the computed height. This significantly improves the layout in servo#6643.
glennw
force-pushed
the
fix-height-again
branch
from
b01591a
to
b9fea3d
Compare
|
@pcwalton Fixed up those typos / renames |
|
@bors-servo: r+ |
|
📌 Commit b9fea3d has been approved by |
|
⌛ Testing commit b9fea3d with merge 028707f... |
bors-servo
pushed a commit
that referenced
this pull request
Aug 3, 2015
Fix percentage height calculation, absolute containing block height calculations. It's not possible to correctly determine during the css cascade whether the container height is explicitly specified. Additionally, the spec https://drafts.csswg.org/css2/visudet.html#the-height-property says this should affect the *used* height, rather than the computed height. This significantly improves the layout in #6643. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6903) <!-- Reviewable:end -->
mbrubeck
added
S-awaiting-merge
|
@bors-servo retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to correctly determine during the css cascade whether the container height
is explicitly specified. Additionally, the spec https://drafts.csswg.org/css2/visudet.html#the-height-property says this should affect the used height, rather than the computed height.
This significantly improves the layout in #6643.