Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compositor layers are collected when removed from layout. #7182

Merged
merged 1 commit into from Aug 13, 2015
Merged

Ensure compositor layers are collected when removed from layout. #7182

merged 1 commit into from Aug 13, 2015

Conversation

glennw
Copy link
Member

@glennw glennw commented Aug 13, 2015

Needed for #6643 and #7134.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 13, 2015
@glennw
Copy link
Member Author

glennw commented Aug 13, 2015

r? @pcwalton or @mrobinson

@metajack metajack mentioned this pull request Aug 13, 2015
Closed
40 tasks
@pcwalton
Copy link
Contributor

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 6506468 has been approved by pcwalton

@bors-servo
Copy link
Contributor

⌛ Testing commit 6506468 with merge 1542a87...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Aug 13, 2015
bors-servo pushed a commit that referenced this pull request Aug 13, 2015
Auto merge of #7182 - glennw:collect-old-layers, r=pcwalton
1542a87 
Ensure compositor layers are collected when removed from layout.

Needed for #6643 and #7134.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7182)
<!-- Reviewable:end -->
@pcwalton
Copy link
Contributor

I wonder if this might help improve stability on Mac as well.

@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit 6506468 into servo:master Aug 13, 2015
@glennw glennw deleted the collect-old-layers branch December 12, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@glennw @pcwalton @bors-servo @highfive @gw3583