New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glutin update #8172
Closed
Closed
glutin update #8172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Oct 23, 2015
|
Submitted PR servo/surfman#35 to get everything on the latest version of gl_generator. Once that is merged, then updating to the latest versions of |
nox
added
S-fails-tidy
`./mach test-tidy` reported errors.
S-blocked-on-external
Something, somewhere else, needs to happen before this PR can be merged.
and removed
S-fails-tidy
`./mach test-tidy` reported errors.
labels
Oct 24, 2015
Update: servo/surfman#35 has merged |
frewsxcv
added
S-needs-code-changes
Changes have not yet been made that were requested by a reviewer.
and removed
S-awaiting-review
There is new code that needs to be reviewed.
S-blocked-on-external
Something, somewhere else, needs to happen before this PR can be merged.
labels
Oct 25, 2015
Moved to #8224. |
bors-servo
pushed a commit
that referenced
this pull request
Oct 27, 2015
Upgrade glutin and related packages Updated version of #8172. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8224) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Oct 27, 2015
Upgrade glutin and related packages Updated version of #8172. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8224) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this pull request
Oct 27, 2015
Upgrade glutin and related packages Updated version of #8172. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8224) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look at the change in ports/glutin/Cargo.toml (other changes come from the
cargo-update
command). Glutin doesn't have a window feature anymore.