Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global fields from DOM objects #9255

Merged
merged 11 commits into from Jan 12, 2016
Merged

Remove global fields from DOM objects #9255

merged 11 commits into from Jan 12, 2016

Conversation

chkimes
Copy link
Contributor

@chkimes chkimes commented Jan 11, 2016

Fixes #9227

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 11, 2016
@nox
Copy link
Contributor

nox commented Jan 11, 2016

As mentioned on IRC, please rename method to just global.

@nox nox self-assigned this Jan 11, 2016
@nox
Copy link
Contributor

nox commented Jan 11, 2016

Please squash the two last commits together and rename the method. Apart from that, r=me.

-S-awaiting-review +S-needs-code-changes

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, 16 of 16 files at r12.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

components/script/dom/bindings/reflector.rs, line 80 [r11] (raw file):
Rename that to global.

Comments from the review on Reviewable.io

@nox nox added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 11, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Jan 12, 2016
@KiChjang
Copy link
Contributor

-S-awaiting-review

@bors-servo r=nox

Thanks for working on this!

Reviewed 1 of 2 files at r1, 17 of 17 files at r13.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from the review on Reviewable.io

@KiChjang KiChjang removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 12, 2016
@bors-servo
Copy link
Contributor

📌 Commit ce60758 has been approved by nox

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 12, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit ce60758 with merge 53c4a78...

bors-servo pushed a commit that referenced this pull request Jan 12, 2016
Auto merge of #9255 - ckimes89:remove-globalfield, r=nox
53c4a78 
Remove global fields from DOM objects

Fixes #9227

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9255)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit ce60758 into servo:master Jan 12, 2016
@bors-servo bors-servo mentioned this pull request Jan 12, 2016
Merged
@chkimes chkimes deleted the remove-globalfield branch January 12, 2016 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chkimes @nox @KiChjang @bors-servo @highfive