Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taplo is very slow on MacOS #31440

Closed
mrobinson opened this issue Feb 28, 2024 · 1 comment · Fixed by #31452
Closed

taplo is very slow on MacOS #31440

mrobinson opened this issue Feb 28, 2024 · 1 comment · Fixed by #31452

Comments

@mrobinson
Copy link
Member

Taplo seems to have an issue on MacOS with processing speed. This is what I see when I run ./mach fmt

$ time ./mach fmt

real	0m19.056s
user	0m2.091s
sys	0m7.640s

If I comment out taplo formatting, I see:

$ time ./mach fmt

real	0m1.622s
user	0m1.320s
sys	0m0.145s
@nicoburns
Copy link
Contributor

I suspect a filesystem issue: that's usually the cause of perf differences between linux and macos. I notice taplo-cli is using the glob crate which is known to be slow and suggests that its doing custom filesystem walking logic. I bet this could be sped up by converting it to use the walkdir/ignore crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants