Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing crown warning issued when running ./mach doc #31804

Closed
mrobinson opened this issue Mar 21, 2024 · 0 comments · Fixed by #31805
Closed

Missing crown warning issued when running ./mach doc #31804

mrobinson opened this issue Mar 21, 2024 · 0 comments · Fixed by #31805
Labels
C-untriaged New issues that haven't been triaged yet

Comments

@mrobinson
Copy link
Member

When running ./mach doc the only warning we have now is this one:

warning: unknown lint: `crown_is_not_used`
  --> components/script/lib.rs:11:9
   |
11 | #![deny(crown_is_not_used)]
   |         ^^^^^^^^^^^^^^^^^
   |
note: the lint level is defined here
  --> components/script/lib.rs:10:9
   |
10 | #![warn(unknown_lints)]
   |         ^^^^^^^^^^^^^

./mach doc should be able to run without warnings so that we can prevent future ones.
@mrobinson mrobinson added the C-untriaged New issues that haven't been triaged yet label Mar 21, 2024
mrobinson added a commit to mrobinson/servo that referenced this issue Mar 21, 2024
@mrobinson
crown: Do not issue a warning when crown cannot be found
f29047d 
This is important because tools like clippy and rustdoc cannot use crown
and should not issue warnings.

Fixes servo#31804.
@mrobinson mrobinson mentioned this issue Mar 21, 2024
Merged
4 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Mar 21, 2024
@mrobinson
crown: Do not warn about crown for rustdoc or clippy
ae398af 
Fixes servo#31804.
mrobinson added a commit to mrobinson/servo that referenced this issue Mar 21, 2024
@mrobinson
crown: Do not warn about crown for rustdoc or clippy
ef5ad4a 
Fixes servo#31804.
github-merge-queue bot pushed a commit that referenced this issue Mar 21, 2024
@mrobinson
crown: Do not warn about crown for rustdoc or clippy (#31805)
755701f 
Fixes #31804.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-untriaged New issues that haven't been triaged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crown: Do not warn about crown for rustdoc or clippy mrobinson/servo
1 participant
@mrobinson