Skip to content
This repository has been archived by the owner on Jun 8, 2020. It is now read-only.

Use DirectWrite on Windows GNU #123

Merged
merged 1 commit into from
Dec 3, 2016
Merged

Conversation

UK992
Copy link
Contributor

@UK992 UK992 commented Nov 24, 2016

r? @vvuk or @larsbergstrom


This change is Reviewable

@vvuk
Copy link
Contributor

vvuk commented Nov 24, 2016

r+ but I assume this is part of a larger set of patches? We need to actually look at what's going on in Skia -- I believe we use Skia through Moz2D only for canvas (and maybe SVG, if there's any SVG support in Servo?). But I have no idea how fonts are selected/used in our usage of Skia.

@UK992
Copy link
Contributor Author

UK992 commented Nov 27, 2016

Canvas font related methods (fillText() and strokeText()) are not supported yet, but other canvas methods works the same.

@larsbergstrom
Copy link
Contributor

@bors-servo r=vvuk

@bors-servo
Copy link

📌 Commit 261000c has been approved by vvuk

@bors-servo
Copy link

⚡ Test exempted - status

@bors-servo bors-servo merged commit 261000c into servo:master Dec 3, 2016
bors-servo pushed a commit that referenced this pull request Dec 3, 2016
Use DirectWrite on Windows GNU

r? @vvuk or @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/123)
<!-- Reviewable:end -->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants