Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 0.2.x release to fix rustc error #210

Closed
Mark-Simulacrum opened this issue Aug 19, 2018 · 3 comments
Closed

New 0.2.x release to fix rustc error #210

Mark-Simulacrum opened this issue Aug 19, 2018 · 3 comments

Comments

@Mark-Simulacrum
Copy link

We use the 0.2.29 release in perf.rust-lang.org's html5ever benchmark which currently errors with this error. Can we release a 0.2.30 with a fix? I can try to prepare a PR it would be accepted.

error: macro-expanded `macro_export` macros from the current crate cannot be referred to by absolute paths
  --> /home/alex/.cargo/registry/src/github.com-1ecc6299db9ec823/string_cache-0.2.29/src/lib.rs:71:13
   |
71 |     pub use atom;
   |             ^^^^
   |
note: the macro is defined here
  --> /tmp/.tmpFazpQK/target/debug/build/string_cache-589ae806702507d8/out/atom_macro.rs:2:1
   |
2  | / macro_rules! atom {
3  | | (\"sdev\") => { $crate::Atom { unsafe_data: 0x2 } };
4  | | (\"onstart\") => { $crate::Atom { unsafe_data: 0x100000002 } };
5  | | (\"overflow\") => { $crate::Atom { unsafe_data: 0x200000002 } };
...  |
127| | (\"stroke-miterlimit\") => { $crate::Atom { unsafe_data: 0x4f400000002 } };
127| | }
   | |_^

error: aborting due to previous error

cc rust-lang/rust#53495

@jdm
Copy link
Member

jdm commented Aug 20, 2018

I would accept and publish a change to fix that.

@Mark-Simulacrum
Copy link
Author

@jdm There doesn't seem to be a tag for 0.2.29, is there a chance it's just not been pushed?

@jdm
Copy link
Member

jdm commented Aug 21, 2018

No, we just aren't always great at tagging releases.

@jdm jdm closed this as completed Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants