Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-decoration shorthand should support style and color #25

Open
Loirooriol opened this issue Mar 19, 2024 · 4 comments · May be fixed by #33
Open

text-decoration shorthand should support style and color #25

Loirooriol opened this issue Mar 19, 2024 · 4 comments · May be fixed by #33

Comments

@Loirooriol
Copy link
Contributor

servo/servo@689b413 and servo/servo@928bd0d added support for text-decoration-style and text-decoration-color on Servo. However, the shorthand wasn't modified:

sub_properties="text-decoration-line
${' text-decoration-style text-decoration-color text-decoration-thickness' if engine == 'gecko' else ''}"

This seems something that we should fix after catching up with the style updates.

@MunishMummadi
Copy link
Contributor

MunishMummadi commented Apr 3, 2024

Hey @Loirooriol I tried to understand the code and I think sub_properties should be updated with.

sub_properties="text-decoration-line ${' text-decoration-style text-decoration-color' if engine == 'servo' else ''} ${' text-decoration-style text-decoration-color text-decoration-thickness' if engine == 'gecko' else ''}"

Let me know if I am wrong.

@mrobinson
Copy link
Member

@MunishMummadi The proposal here was to wait until Stylo has been updated to incorporate all of the changes from upstream.

@Loirooriol
Copy link
Contributor Author

Yeah. Well I guess it's not a big deal to fix it beforehand, but that code is not enough, the parser and serializer need to change too.

@MunishMummadi
Copy link
Contributor

Got it!!!! thanks for info @Loirooriol @mrobinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants