New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text-decoration
shorthand should support style and color
#25
Comments
Hey @Loirooriol I tried to understand the code and I think sub_properties="text-decoration-line ${' text-decoration-style text-decoration-color' if engine == 'servo' else ''} ${' text-decoration-style text-decoration-color text-decoration-thickness' if engine == 'gecko' else ''}" Let me know if I am wrong. |
@MunishMummadi The proposal here was to wait until Stylo has been updated to incorporate all of the changes from upstream. |
Yeah. Well I guess it's not a big deal to fix it beforehand, but that code is not enough, the parser and serializer need to change too. |
Got it!!!! thanks for info @Loirooriol @mrobinson |
servo/servo@689b413 and servo/servo@928bd0d added support for
text-decoration-style
andtext-decoration-color
on Servo. However, the shorthand wasn't modified:stylo/style/properties/shorthands/text.mako.rs
Lines 10 to 11 in 3d41c54
This seems something that we should fix after catching up with the style updates.
The text was updated successfully, but these errors were encountered: