Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Stylo to servo/stylo#33 #32090

Closed
wants to merge 0 commits into from
Closed

Bump Stylo to servo/stylo#33 #32090

wants to merge 0 commits into from

Conversation

MunishMummadi
Copy link
Contributor

@MunishMummadi MunishMummadi commented Apr 15, 2024 •
edited

Description:

  1. This consists of updated Cargo.toml and Cargo.lock based on the stylo PR
  2. Changes update the branch of stylo to specific commit - hash from stylo PR
  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

It is related to stylo issue

@Loirooriol Loirooriol added T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Apr 15, 2024
@github-actions github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Apr 15, 2024
@github-actions GitHub Actions
Copy link

🔨 Triggering try run (#8693853251) for Linux WPT

@github-actions GitHub Actions
Copy link

Test results for linux-wpt-layout-2013 from try job (#8693853251):

Flaky unexpected result (16)
  • TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
    • TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works.

      Test timed out

  • CRASH [expected PASS] /_mozilla/mozilla/webgl/tex_image_2d_abv.html
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • FAIL [expected PASS] subtest: listeners are called correct number of times

      assert_equals: expected 9 but got 8

  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html
    • TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up

      Test timed out

  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • FAIL [expected PASS] subtest: border-image sec-fetch-site - HTTPS downgrade (header not sent)

      assert_unreached: Reached unreachable code

  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored

      assert_equals: expected "?pass" but got "?fail"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])

  • OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • FAIL [expected PASS] subtest: DOMParser

      assert_unreached: got unexpected load event Reached unreachable code

    • FAIL [expected PASS] subtest: createHTMLDocument

      assert_unreached: got unexpected error event Reached unreachable code

    • FAIL [expected PASS] subtest: <template>

      assert_unreached: got unexpected error event Reached unreachable code

  • TIMEOUT /resource-timing/entries-for-network-errors.sub.https.html
    • TIMEOUT [expected FAIL] subtest: A ResourceTiming entry should be created for network error of type Mixed content

      Test timed out

    • NOTRUN [expected TIMEOUT] subtest: A ResourceTiming entry should be created for network error of type only-if-cached resource that was not cached
  • TIMEOUT /resource-timing/test_resource_timing.html (#25720)
    • FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)

      assert_equals: expected 25311744 but got 25312000

  • CRASH [expected OK] /url/failure.html (#28574)
  • TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:

      Test timed out

  • OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
Stable unexpected results that are known to be intermittent (12)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
    • PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
  • OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
    • PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected FAIL] subtest: Contenteditable element should support autofocus

      Test timed out

    • NOTRUN [expected FAIL] subtest: Element with tabindex should support autofocus
    • NOTRUN [expected PASS] subtest: Non-HTMLElement should not support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
    • NOTRUN [expected FAIL] subtest: Area element should support autofocus
  • OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/track/track-element/no-cuechange-before-play.html (#31014)
    • FAIL [expected TIMEOUT] subtest: Ensure that the 'cuechange' event is not fired before video playback has begun.

      assert_true: Not expecting event, but got canplaythrough event expected true got false

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
  • OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
  • OK /html/syntax/parsing/DOMContentLoaded-defer.html (#21550)
    • PASS [expected FAIL] subtest: The end: DOMContentLoaded and defer scripts
  • TIMEOUT [expected OK] /webmessaging/without-ports/017.html (#24486)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, about:blank

      Test timed out

Stable unexpected results (6)
  • FAIL [expected PASS] /css/css-pseudo/target-text-text-decoration-001.html
  • OK /css/css-text-decor/parsing/text-decoration-valid.html
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "solid" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "currentcolor" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "double overline underline" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "underline overline line-through red" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "rgba(10, 20, 30, 0.4) dotted" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "underline dashed green" should set the property value
  • PASS [expected FAIL] /css/css-text-decor/text-decoration-line-recalc.html
  • FAIL [expected PASS] /css/css-text-decor/text-decoration-shorthands-001.html
  • FAIL [expected PASS] /css/css-text-decor/text-decoration-shorthands-002.html
  • PASS [expected FAIL] /css/css-text-decor/text-decoration-skip-ink-003.html

@github-actions GitHub Actions
Copy link

Test results for linux-wpt-layout-2020 from try job (#8693853251):

Flaky unexpected result (16)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
  • OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
    • PASS [expected FAIL] subtest: Matching font-style: 'italic' should prefer 'oblique 40deg 50deg' over 'oblique 5deg 10deg'
    • PASS [expected FAIL] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique -60deg -40deg' over 'oblique -10deg'
  • TIMEOUT [expected PASS] /encoding/streams/stringification-crash.html
  • TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html
    • TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up

      Test timed out

  • TIMEOUT /fetch/fetch-later/new-window.tentative.https.window.html (#32036)
    • TIMEOUT [expected FAIL] subtest: A same-origin window[target=''][features='0'] can trigger fetchLater.

      Test timed out

    • TIMEOUT [expected FAIL] subtest: A same-origin window[target=''][features='1'] can trigger fetchLater.

      Test timed out

    • TIMEOUT [expected FAIL] subtest: A same-origin window[target=''][features='2'] can trigger fetchLater.

      Test timed out

    • TIMEOUT [expected FAIL] subtest: A same-origin window[target='_blank'][features='0'] can trigger fetchLater.

      Test timed out

    • TIMEOUT [expected FAIL] subtest: A same-origin window[target='_blank'][features='1'] can trigger fetchLater.

      Test timed out

    • TIMEOUT [expected FAIL] subtest: A same-origin window[target='_blank'][features='2'] can trigger fetchLater.

      Test timed out

  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)

      Test timed out

  • OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-referrer.window.html (#29081)
    • PASS [expected TIMEOUT] subtest: no-referrer referrer policy used to create the starting page
  • OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])

  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-user-activation-sticky.tentative.sub.window.html
    • TIMEOUT [expected FAIL] subtest: Allow top with user activation + user activation

      Test timed out

  • OK /html/semantics/embedded-content/the-img-element/non-active-document.html (#21544)
    • FAIL [expected PASS] subtest: DOMParser

      assert_unreached: got unexpected load event Reached unreachable code

    • FAIL [expected PASS] subtest: createHTMLDocument

      assert_unreached: got unexpected error event Reached unreachable code

    • FAIL [expected PASS] subtest: <template>

      assert_unreached: got unexpected error event Reached unreachable code

  • OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
  • OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
  • OK /workers/WorkerGlobalScope-close.html (#23064)
    • PASS [expected FAIL] subtest: Test sending a message after closing.
Stable unexpected results that are known to be intermittent (11)
  • TIMEOUT /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
    • FAIL [expected TIMEOUT] subtest: sec-fetch-site - Not sent to non-trustworthy cross-site destination, no attributes

      promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."

    • TIMEOUT [expected NOTRUN] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes

      Test timed out

  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''

      assert_unreached: load should not be fired Reached unreachable code

  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
  • OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
    • FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

      assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])

  • TIMEOUT [expected OK] /html/browsers/history/the-history-interface/traverse_the_history_write_onload_1.html (#21581)
    • TIMEOUT [expected PASS] subtest: Traverse the history when a history entry is written in the load event

      Test timed out

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • TIMEOUT [expected OK] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
    • NOTRUN [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
  • OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
    • PASS [expected FAIL] subtest: document.write in an imported module
  • OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
Stable unexpected results (11)
  • FAIL [expected PASS] /css/css-pseudo/target-text-text-decoration-001.html
  • OK /css/css-text-decor/parsing/text-decoration-computed.html
    • PASS [expected FAIL] subtest: Property text-decoration value 'none'
    • PASS [expected FAIL] subtest: Property text-decoration value 'line-through'
    • PASS [expected FAIL] subtest: Property text-decoration value 'solid'
    • PASS [expected FAIL] subtest: Property text-decoration value 'currentcolor'
    • PASS [expected FAIL] subtest: Property text-decoration value 'double overline underline'
    • PASS [expected FAIL] subtest: Property text-decoration value 'underline overline line-through red'
    • PASS [expected FAIL] subtest: Property text-decoration value 'rgba(10, 20, 30, 0.4) dotted'
    • PASS [expected FAIL] subtest: Property text-decoration value 'underline dashed rgb(0, 255, 0)'
  • OK /css/css-text-decor/parsing/text-decoration-valid.html
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "solid" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "currentcolor" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "double overline underline" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "underline overline line-through red" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "rgba(10, 20, 30, 0.4) dotted" should set the property value
    • PASS [expected FAIL] subtest: e.style['text-decoration'] = "underline dashed green" should set the property value
  • FAIL [expected PASS] /css/css-text-decor/text-decoration-dotted-002.html
  • PASS [expected FAIL] /css/css-text-decor/text-decoration-line-recalc.html
  • OK /css/css-text-decor/text-decoration-serialization.tentative.html
    • PASS [expected FAIL] subtest: text-decoration shorthand serialization
  • FAIL [expected PASS] /css/css-text-decor/text-decoration-shorthands-001.html
  • FAIL [expected PASS] /css/css-text-decor/text-decoration-shorthands-002.html
  • FAIL [expected PASS] /css/css-text-decor/text-decoration-style-multiple.html
  • FAIL [expected PASS] /css/css-text-decor/text-decoration-subelements-003.html
  • PASS [expected FAIL] /css/css-variables/variable-reference-visited.html

@github-actions GitHub Actions
Copy link

⚠️ Try run (#8693853251) failed.

@MunishMummadi
Copy link
Contributor Author

MunishMummadi commented Apr 23, 2024 •
edited

hey @Loirooriol
My analysis on tests results linux-wpt-layout-2020

Some tests that were previously failing are now passing:

  1. /css/css-text-decor/parsing/text-decoration-computed.html
    • All subtests that were previously failing are now passing.
  2. /css/css-text-decor/parsing/text-decoration-valid.html
    • All subtests that were previously failing are now passing.
  3. /css/css-text-decor/text-decoration-serialization.tentative.html
    • The subtest "text-decoration shorthand serialization" that was previously failing is now passing.
  4. /css/css-variables/variable-reference-visited.html
    • This test is now passing, whereas it was previously failing.

The test results also show some flaky and intermittent failures in other tests, but those are not directly related to the changes made in the updated file.

Positive aspects

  1. Several tests that were previously failing are now passing, particularly in the "css-text-decor" module. This suggests that the changes have resolved some issues and improved the implementation of certain CSS text decoration features.
  2. The passing of the "variable-reference-visited.html" test indicates that the changes may have also fixed some issues related to CSS variables.

Negative aspects

  1. Despite the improvements, there are still several tests in the "css-text-decor" module that continue to fail. This implies that the changes did not comprehensively address all the issues related to CSS text decoration.
  2. The failure of tests like "text-decoration-shorthands-001.html" and "text-decoration-shorthands-002.html" suggests that there might be ongoing problems with the implementation of text decoration shorthands.

Overall, while some tests have improved and are now passing, there are still several CSS text decoration tests that continue to fail even after the updated file.

@Loirooriol
Copy link
Contributor

The analysis I wanted was more like:

@Loirooriol
Copy link
Contributor

Anyways these failures look acceptable.
But please use a better issue and commit message.
Possibly title "Add support of style & color for text-decoration" like in the stylo PR, or something like "Bump Stylo to servo/stylo#33" and explain what it does in the description.

@MunishMummadi MunishMummadi changed the title To perform tests on changes in stylo style/properties/shorthands/text.mako.rs Bump Stylo to servo/stylo#33 Apr 25, 2024
@MunishMummadi
Copy link
Contributor Author

The analysis I wanted was more like:

Noted. I will try to improve my knowledge on tests. Thank you. Learned a lot.

@MunishMummadi MunishMummadi force-pushed the tests-text-25 branch 6 times, most recently from aea2d81 to 2109afc Compare April 26, 2024 01:04
@MunishMummadi MunishMummadi mentioned this pull request Apr 26, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MunishMummadi @Loirooriol