Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement baseline-source #26

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Conversation

MunishMummadi
Copy link
Contributor

@MunishMummadi MunishMummadi commented Mar 26, 2024

Description

  • Changed the attribute from servo-2013 to servo.
  • Ran cargo build --features servo and there are no errors.
  • It is part of the issue

Copy link
Contributor

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you linked to the wrong issue

@MunishMummadi
Copy link
Contributor Author

MunishMummadi commented Mar 26, 2024

Oops. Sorry. Updated it.

Changed the obsolete servo-2013 into servo.
@Loirooriol
Copy link
Contributor

I have rebased your patch since I upgraded main. Also provided a better commit message.

@Loirooriol Loirooriol added this pull request to the merge queue Mar 31, 2024
Merged via the queue into servo:main with commit c22dd97 Mar 31, 2024
3 checks passed
@MunishMummadi MunishMummadi deleted the servo2013 branch April 2, 2024 17:52
Loirooriol pushed a commit that referenced this pull request Apr 9, 2024
Changed the obsolete servo-2013 into servo.
Loirooriol pushed a commit that referenced this pull request Apr 13, 2024
Changed the obsolete servo-2013 into servo.
Loirooriol pushed a commit that referenced this pull request Apr 15, 2024
Changed the obsolete servo-2013 into servo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants