Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining unsafe code #112

Closed
wants to merge 1 commit into from
Closed

Conversation

joshlf
Copy link

@joshlf joshlf commented Oct 25, 2023

This removes the remaining unsafe code (note that the README says that the crate is written in "safe Rust"). It does so at the cost of adding a new dependency, so feel free to just close this if it's determined to be not worth the tradeoff.

@Manishearth
Copy link
Member

Yeah unfortunately this is at the root of a number of deptrees so we're somewhat careful about deps. Fine to update the readme to say "except for one function" and link to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants