Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Unicode 10.0.0 and improve packaging #44

Merged
merged 2 commits into from
Jul 6, 2017

Conversation

behnam
Copy link
Contributor

@behnam behnam commented Jul 6, 2017

  • Upgrade to Unicode 10.0.0 is straightforward. One of the unit tests (for code points falling back to default value in Unicode 9.0.0) needed update, so I also updated the structure of the unit test.

  • To address cargo test doesn't work from crates.io #43, I have excluded all non-src directories, as they all depend on the text files in the data dir, which we don't want to include.


This change is Reviewable

@behnam behnam requested a review from mbrubeck July 6, 2017 18:22
@behnam behnam self-assigned this Jul 6, 2017
@behnam behnam requested a review from Manishearth July 6, 2017 18:22
@mbrubeck
Copy link
Contributor

mbrubeck commented Jul 6, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 3585972 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

⌛ Testing commit 3585972 with merge bfd439c...

bors-servo pushed a commit that referenced this pull request Jul 6, 2017
Upgrade to Unicode 10.0.0 and improve packaging

* Upgrade to Unicode 10.0.0 is straightforward. One of the unit tests (for code points falling back to default value in Unicode 9.0.0) needed update, so I also updated the structure of the unit test.

* To address <#43>, I have excluded all non-`src` directories, as they all depend on the text files in the `data` dir, which we don't want to include.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/unicode-bidi/44)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing bfd439c to master...

@bors-servo bors-servo merged commit 3585972 into servo:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants