Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Upgrade the reftest list format #2111

Open
kvark opened this issue Nov 27, 2017 · 0 comments
Open

[RFC] Upgrade the reftest list format #2111

kvark opened this issue Nov 27, 2017 · 0 comments

Comments

@kvark
Copy link
Member

kvark commented Nov 27, 2017

Looking into the growing list of supported prefixes/functions now: https://github.com/servo/webrender/pull/2105/files#diff-f340cf8bfec5772b98e4211803fbe7cdR219

The format chosen ("xxx.list") doesn't seem to scale nicely, given that all the prefixes are expected to come on the same line... so the tests don't align, and the very fact we are using a simple text format falls down here.

I suggest describing the tests in a structured format, e.g. RON:

[
  (
    op: NonEqual("text.yaml", "blank.yaml"), // or we could have src/dst fields
    fuzz: (diff: 1, count: 100),
    aa: false,
    platforms: [Linux],
    draw_calls: 4,
  ),
  (
    op: Equal("decorations.yaml", "decorations-suite.png"),
    aa: true,
  )
]
@kvark kvark changed the title Upgrade the reftest list format [RFC] Upgrade the reftest list format Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant