Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: synthetic bold not working #2269

Closed
Gankra opened this issue Jan 8, 2018 · 7 comments
Closed

macos: synthetic bold not working #2269

Gankra opened this issue Jan 8, 2018 · 7 comments

Comments

@Gankra
Copy link
Contributor

Gankra commented Jan 8, 2018

On my text stress test, the synthetic bold case doesn't seem to be working:

screen shot 2018-01-08 at 2 11 51 pm

left: vanilla firefox
right: webrender-firefox

The html is (problematic parts are the ones with "basic" as the font):

<p style="font-weight: bold">
Lorem ipsum dolor sit amet, consectetur adipiscing elit,
<span style="color: rgba(0,0,0, 0.5)">
sed do eiusmod tempor incididunt ut labore et
</span>
<span style="font-family: &quot;basic&quot;">
dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex
</span>
<span style="font-family: &quot;basic&quot;; color: rgba(0,0,0, 0.5)">
ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
</span>
<span style="font-family: -apple-system, sans-serif">
velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident,
</span>
sunt in culpa qui officia deserunt mollit anim id est laborum.
</p>

"basic" is a font I'm loading from Adobe Edge Fonts which doesn't provide a bold variant.

@Gankra
Copy link
Contributor Author

Gankra commented Jan 8, 2018

Confirmed this works fine on windows.

@Gankra
Copy link
Contributor Author

Gankra commented Jan 8, 2018

(Is there a way to test synthetics in wrench?)

@lsalzman
Copy link
Contributor

lsalzman commented Jan 8, 2018

You just need to use synthetic-bold: true for wrench

@Gankra
Copy link
Contributor Author

Gankra commented Jan 8, 2018

Seems to work in wrench, probably a gecko bindings issue? (might also be font-specific, idk)

@lsalzman
Copy link
Contributor

lsalzman commented Jan 8, 2018

If you disable WR, does that case work?

@Gankra
Copy link
Contributor Author

Gankra commented Jan 8, 2018

Yes, the screenshot shows it working without wr.

@Gankra
Copy link
Contributor Author

Gankra commented Jan 8, 2018

Bugzilled since it seems like a gecko issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1428874

@Gankra Gankra closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants