-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(clean-slate): reimagined certain packages, removed GenerateSW #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuCanhGH
changed the title
refactor(clean-slate): removed GenerateSW, repurposed
refactor(clean-slate): reimagined serwist/next, repurposed serwist/sw, and removed GenerateSW
Nov 30, 2023
@serwist/sw
DuCanhGH
changed the title
refactor(clean-slate): reimagined serwist/next, repurposed serwist/sw, and removed GenerateSW
refactor(clean-slate): reimagined some packages, removed GenerateSW
Nov 30, 2023
DuCanhGH
changed the title
refactor(clean-slate): reimagined some packages, removed GenerateSW
refactor(clean-slate): reimagined certain packages, removed GenerateSW
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@serwist/next
.publicExcludes
,buildExcludes
. Useexclude
instead.aggressiveFrontEndNavCaching
to reassess its usefulness.browserslist
.swSrc
.extendDefaultRuntimeCaching
. Use the spread syntax instead (useimport { defaultCache } from "@serwist/next/browser"
to import the default runtimeCaching array).fallbacks
to investigate module-friendly alternatives.swcMinify
.watchWorkersInDev
.cacheStartUrl
,dynamicStartUrl
, anddynamicStartUrl
. These shall be re-added only when their use cases are made more clear to me.workboxOptions
with the plugin's options.swc-loader
,terser-minify
,webpack-builders
,... (we now leverageChildCompilationPlugin
to compile workers - this change will be backported to@ducanh2912/next-pwa@10
)@serwist/sw.installSerwist
is provided as a replacement.swSrc
is now a required property.11.0.0
to14.0.0
.@serwist/sw.installSerwist
).examples/next-basic/app/sw.ts
to see howinstallSerwist
should be used.@serwist/sw
.