Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate cell object from prefab #8

Closed
rfadeev opened this issue Oct 4, 2017 · 3 comments
Closed

Instantiate cell object from prefab #8

rfadeev opened this issue Oct 4, 2017 · 3 comments

Comments

@rfadeev
Copy link
Contributor

rfadeev commented Oct 4, 2017

Is there any special reason for instantiating cells from cellBase which is set to inactive in FancyScrollView's Awake? I was thinking that support of instantiating from prefab can be useful, plus it would allow not having disabled cellBase object in heirarchy.

@setchi
Copy link
Owner

setchi commented Oct 17, 2017

Thank you.

Certainly, I think it is convenient to instantiate from prefab.
I tried it, there seems to be no problem. I updated samples. 32d4195
Please tell me if you have any comments.

@rfadeev
Copy link
Contributor Author

rfadeev commented Oct 17, 2017

@setchi Great, thanks! Actually I was thinking to implement this, but was afraid of too drastic API change since FancyScrollView users need to extract their objects from heirarchies to prefabs, otherwise they would have enabled instance of "original" cell base. For example Unity UI Extensions project could be affected if they would like to update their FancyScrollView code to this version.

One comment: prefabs for examples 1 and 2 are disabled, while for examples 3 and 4 are enabled. Is it intended?

@setchi
Copy link
Owner

setchi commented Oct 17, 2017

I did not intend. Fixed! 8ed0641
Thanks.

@rfadeev rfadeev closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants