Of/kill stale started members #31
Conversation
| StartingMembers = remove_stale_starting_members(Pool, StartingMembers0, | ||
| StartTimeout), | ||
| case lists:keymember(Ref, 1, StartingMembers) of | ||
| #pool{starting_members = StartingMembers}= remove_stale_starting_members(Pool, StartingMembers0, StartTimeout), |
There was a problem hiding this comment.
Looking at this I bet there's a cleanup to not have to pass StartingMembers since it is inside the Pool. But worth saving that for later :)
There was a problem hiding this comment.
I think we want to capture the resulting pool so we can return it
There was a problem hiding this comment.
I agree, we should capture it so we can return it. In this case, the only difference between the pool returned by remove_stale_starting_members and the pool returned in the function is the field starting_members which is getting set correctly. However, that is not clear looking at the code.
|
Nice cleanups. Please squash to a single commit and I'll get this merged asap. |
|
On second, thought, please squash and merge it yourself :) You should now have access. |
Pooler/_starter previously had a bug where if a started process took longer than the start_member_timeout but did not crash, the process would get orphaned. This fix includes modifications to the starter that change its lifecycle. The starter will now wait to be stopped by the pooler gen_server via either the stop_member_async or stop apis. The stop_member_async api is called on the error path and the stop api is called on the success path. Additionally, pooler gen_server bookkeeping is fixed to correctly update the pool state with regard to starting members. Previously, pool record was not updated with the starting members list returned from the non_stale filter.
oferrigni
force-pushed
the
of/kill_stale_started_members
branch
from
f93525d
to
4c0a457
Compare
Of/kill stale started members
Clean up starting members that took too long to start. Corrects some bookkeeping issues with regard to starting members.