Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sethandleah.
Regarding facebook/react#15315
I was able to get this working with the following steps. I hope this helps in resolving the issue on your side.
react
from the lib bundle by specifying it as external inwebpack.config.js
.children
reference, replace unusedcontent
Steps to reproduce
sethandleah/react-lib
sethandleah/myapp
cd myapp
npm i
cd ../react-lib
npm install
npm link ../myapp/node_modules/react
- important stepnpm run build
- important stepnpm link
cd ../myapp
npm link react-lib
npm start
To see the above, do the following:
Uncomment these lines at
myapp/src/App.js
:The comment out these line, at
myapp/src/App.js
: