Add test for 3.7 compatible syntax #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
python-3.7-ast-compatible
branch
from
625620d
to
de91236
Compare
|
@sethmlarson The lint check is failing with a mypy error |
|
@davisagli Yeah I'm going to fix that in a separate PR, that's failing main too. |
davisagli
force-pushed
the
python-3.7-ast-compatible
branch
from
de91236
to
771ae0b
Compare
sethmlarson
force-pushed
the
python-3.7-ast-compatible
branch
from
771ae0b
to
71fbf6c
Compare
|
Rebased on main, hopefully now CI won't be failing. |
davisagli
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to pypa/pip#12107, this test ensures that the syntax used in the truststore package is compatible with Python 3.7 (so anyone can call compileall).