Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
sethrj committed Apr 16, 2024
1 parent 791a3f5 commit d3052d6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
10 changes: 1 addition & 9 deletions src/orange/g4org/ProtoConstructor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,7 @@ auto ProtoConstructor::operator()(LogicalVolume const& lv) -> SPUnitProto

//---------------------------------------------------------------------------//
/*!
* Place this PV into the proto.
*
* - proto boundary is already constructed as a parent unit
* - when inlining a child, we explicitly subtract the children
* - "top-level" children don't get subtracted; the parent volume has a
* "background"
* - child is inlined if it's only used once; *its* shape needs to have the
* children subtracted from it explicitly
* - child is inlined if it has no children
* Place this physical volume into the proto.
*/
void ProtoConstructor::place_pv(VariantTransform const& parent_transform,
PhysicalVolume const& pv,
Expand Down
13 changes: 10 additions & 3 deletions src/orange/g4org/ProtoConstructor.hh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ namespace g4org
{
//---------------------------------------------------------------------------//
/*!
* Build a proto-universe from a logical volume.
* Recursively build ORANGE proto-universes from a \c LogicalVolume .
*
* The input to this function is the output of \c LogicalVolumeConverter . This
* class is responsible for "placing" the converted \c PhysicalVolume by
* transforming its children. Depending on heuristics, the children are
* directly inserted into a \c UnitProto as volumes (specifically, the logical
* volume becomes a \c UnitProto::MaterialInput), or a \c LogicalVolume is
* turned into a \em new \c UnitProto that can be used in multiple locations.
*/
class ProtoConstructor
{
Expand Down Expand Up @@ -51,8 +58,8 @@ class ProtoConstructor
PhysicalVolume const& pv,
ProtoInput* proto);

// Number of daughters above which we use a "fill" material
// TODO: make this configurable
// (TODO: make this configurable)
//! Number of daughters above which we use a "fill" material
static constexpr int fill_daughter_threshold() { return 2; }
};

Expand Down

0 comments on commit d3052d6

Please sign in to comment.