Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't send invalid attributes to sentry server #13

Merged
merged 1 commit into from
Jun 3, 2016

Conversation

kennethkalmer
Copy link
Contributor

Since 8.0 (getsentry/sentry#1746) sentry started showing messages on the
screen for invalid attributes sent in the packet.

Currently this client sends ts, uri, project-id, key and
secret in the body. This gets reported as an error in the UI. Prior to
8.0 the error would have just been logged and not easily visible to
users.

This PR simply dissoc's the keys from the map.

@martinklepsch
Copy link
Collaborator

This has been bugging me occasionally so thanks for taking a look & fixing @kennethkalmer! 👏

@martinklepsch martinklepsch merged commit 9edb769 into sethtrain:master Jun 3, 2016
@martinklepsch
Copy link
Collaborator

It might be better to separate the body header arguments to send-packet to make that a bit more obvious but I don't think there's any practical issue with your change so I merged it. If you feel like refactoring that a bit go for it (but keep backwards compatibility in mind).

@martinklepsch
Copy link
Collaborator

This is now released as 1.4.0: https://github.com/sethtrain/raven-clj#changes 🎉

@martinklepsch
Copy link
Collaborator

Ok, 1.4.1 released with actual dependency on Prone. 😅 Please report any bugs.

@martinklepsch
Copy link
Collaborator

😞 ignore what I said, just spotted more issues with #10

@martinklepsch
Copy link
Collaborator

1.4.2 is released :)

@kennethkalmer
Copy link
Contributor Author

Awesome! I was holding back the refactoring until this got merged! Will get another PR through in a few days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants