Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set nil JSON.create_id as it's unnecessary in recent versions of the JSON library #43

Merged
merged 1 commit into from
Aug 6, 2017

Conversation

loganhasson
Copy link
Contributor

Remove JSON.create_id = nil as it is no longer required with the current JSON lib in Ruby. (That line also broke if Oj was used as the JSON parser, as it requires a string argument.)

@olleolleolle
Copy link
Contributor

olleolleolle commented Dec 9, 2016

@loganhasson With a rebase, this would probably be an improvement to what's in master now.

@loganhasson
Copy link
Contributor Author

@olleolleolle rebased and squashed :)

@olleolleolle
Copy link
Contributor

@loganhasson Perhaps re-title the PR to make it prettier in merges, when that happens?

@olleolleolle
Copy link
Contributor

@loganhasson Hi again!

To ease merging this PR: reduce "friction" by not changing the lib/chef-api/version.rb or CHANGELOG.md.

Updating those is another process, for the maintainer to do. Some automated tool probably bumps the version number. And the changelog is amended when the maintainer is good and ready for it.

Your CHANGELOG.md text line is explicit and descriptive. If you use that text in the title of this PR, an automated tool can put it in the changelog file.

Hope this helps!

@tas50 tas50 changed the title Remove JSON.create_id and bump ruby req Don't set nil JSON.create_id as it's unnecessary in recent versions of the JSON library Aug 6, 2017
@tas50 tas50 merged commit 4ee0a8d into chef-boneyard:master Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants