-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for chef_gem resource #66
Conversation
So I thought chef_gem had been in chef for awhile; turns out it arrived in 0.10.10. Given that, is it worth adding support for chef_gem? My inclination is yes, but I want to know what the community thinks. |
+1 |
Hi Jim, I agree that this looks very useful - thanks a lot! At the moment this pull request breaks the build on Travis because the current build matrix includes older versions of Chef that don't have the We have a feature tag This also makes me think we should consider retiring support for Chef 0.9.x from ChefSpec given that it is end of life, which would allow us to remove some code. Cheers, Andrew. |
I completely agree with retiring support for Chef 0.9.x. |
I concur with retiring support for chef 0.9.x. -Jim
|
+1 on chef_gem support and on retiring support for chef 0.9.x... |
…e has braces in its name
add disable action as shown on http://wiki.opscode.com/display/chef/Resources#Resources-Service
Fixes the following warning with Chef 10.6.2: WARN: Setting attributes without specifying a precedence is deprecated and will be removed in Chef 11.0. To set attributes at normal precedence, change code like: `node["key"] = "value"` # Not this to: `node.set["key"] = "value"` # This
Support for remote_file was added with 23f4b34, but the feature never made it to the README.
At the moment, you have to try it out or search the commit/change log to figure out the behavior.
The chef_gem resource was added in chef 0.10.10. We shouldn't add in the chef_gem matcher unless the chef version supports it.
Well, I think I screwed up the git work and picked up several unrelated commits in this branch. I'm going to see if I can straighten it out. |
Also, I'd like comments on the mechanisms I used to ensure the new functionality only runs if it's on a chef version that supports chef_gem. |
I'm going to close this pull request since I screwed up the commit history. I've submitted a second pull request (74) with a re-based commit. |
It would be handy if chefspec supported the 'chef_gem' resource in addition to the 'gem_package' resource.
I'm not sure that some of the actions (:remove, :purge) are strictly necessary for chef_gem but included them to be complete.