add note in case of custom password policy #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the use case for generating a password involves a custom password policy that requires both upper and lower case, this generator isn't guaranteed to satisfy that requirement. Since there's no simple way to ensure that, beyond adding extra complexity to the API, this note should be enough to inform users of the possibility they may need to perform additional checks on any generated passwords.
|
please let me know if different formatting or wording would be more appropriate. |
sethvargo
approved these changes
Sep 9, 2021
|
This pull request has been automatically locked since there has not |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the use case for generating a password involves a custom password policy that requires both upper and lower case, this generator isn't guaranteed to satisfy that requirement.
Since there's no simple way to ensure that, beyond adding extra complexity to the API, this note should be enough to inform users of the possibility they may need to perform additional checks on any generated passwords.