Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-update: Cannot move binary under certain conditions #22

Open
MMulthaupt opened this issue Sep 20, 2019 · 1 comment
Open

Self-update: Cannot move binary under certain conditions #22

MMulthaupt opened this issue Sep 20, 2019 · 1 comment
Labels
needs more info Issue cannot be worked on without further information user experience windows specific

Comments

@MMulthaupt
Copy link
Collaborator

The following problem was found occurring in the wild.

P Could not rename running binary. [godown/bundle/update_self.go:(*Updater)():103] err=rename F:\Application Data\Setlog\***\***.exe F:\Application Data\Setlog\***\~***.old.f556990e1e510594: The process cannot access the file because it is being used by another process., localBinaryPath=F:\Application Data\Setlog\***\***.exe, oldBinaryNewPath=F:\Application Data\Setlog\***\~***.exe.old.f556990e1e510594

This could be caused by pretty much anything. Anti-virus and dodgy security software comes to mind. Failing hard is never a good reaction. How should we deal with cases such as this?

@MMulthaupt MMulthaupt added needs more info Issue cannot be worked on without further information user experience windows specific labels Sep 20, 2019
@dragetd dragetd added this to the trivrost-future milestone Sep 27, 2019
@dragetd
Copy link
Member

dragetd commented Oct 14, 2019

Random suggestion: Like with downloads, keep retrying and show a status-message 'Retrying to update the launcher (the binary is locked by another process)'

@dragetd dragetd modified the milestones: trivrost-future, v1.5.0, v1.5.x Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info Issue cannot be worked on without further information user experience windows specific
Projects
None yet
Development

No branches or pull requests

2 participants