Complete Israel rework #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow 6D war to happen, minor fixes
Israel faces crisis if Arabs become majority
All events functional; fixed settintotrieste#77. Still much more to add, but this should represent all territorial changes in the Levant.
|
Thank you very much! I have looked through the events and they are excellent and a huge step up from the NWO ones. This type of events are definitely the right step forward even if some of them don't work as well as it could be. I will add it to the master right away and look forward to your next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the existing events should be fixed to progress logically and actually happen, fixing #77. A couple of other ones were added to represent major territorial changes, and Israel can now fall. Additionally, everything has been relocalized.
Feel free to take your time approving this. There are a lot of changes, and, though I tested them all, it's possible I missed something.
There is still a lot to be done - I'm not sure whether to make a separate issue for all the things I want to add. Either way, they'll be on hold for the next PR because most of them will not create big changes on the map, and are mostly flavor for players.
Some of the wars still don't work perfectly. For example, the AI is reluctant to join in the Arab-Israeli war. I'm not sure what can be done about that, though. The occupation of South Lebanon is greatly simplified, but, given that so is the Lebanese Civil War, I think it works well enough to get the right result.