Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add round concept for oracle voting #101

Merged
merged 8 commits into from
Feb 27, 2024
Merged

feat: add round concept for oracle voting #101

merged 8 commits into from
Feb 27, 2024

Conversation

devbv
Copy link
Contributor

@devbv devbv commented Feb 23, 2024 •
edited

add a 'round' concept for oracle voting to minimize conflicts and instances of late voting

  • The oracle feeder should submit the oldest block data that exceeds the timestamp provided by the Round.
  • The pre-vote period and the vote period are identical.

I will update the README.md in the x/oracle separately later

@devbv devbv changed the title WIP: add round concept for oracle voting add round concept for oracle voting Feb 23, 2024
jacobhjkim
jacobhjkim requested changes Feb 26, 2024
View reviewed changes
proto/settlus/oracle/v1alpha1/oracle.proto Show resolved Hide resolved
proto/settlus/oracle/v1alpha1/tx.proto Show resolved Hide resolved
x/oracle/keeper/keeper.go Show resolved Hide resolved
@devbv devbv changed the title add round concept for oracle voting feat: add round concept for oracle voting Feb 26, 2024
jacobhjkim
jacobhjkim requested changes Feb 26, 2024
View reviewed changes
x/oracle/keeper/consensus.go Outdated Show resolved Hide resolved
jacobhjkim
jacobhjkim approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@jacobhjkim jacobhjkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jacobhjkim
jacobhjkim requested changes Feb 26, 2024
View reviewed changes
x/oracle/client/cli/tx.go Outdated Show resolved Hide resolved
@devbv devbv merged commit 699eac6 into settlus:main Feb 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skdltmxn skdltmxn skdltmxn approved these changes

@jacobhjkim jacobhjkim jacobhjkim approved these changes

@uhyunpark uhyunpark uhyunpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devbv @skdltmxn @jacobhjkim @uhyunpark