Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inference with Myelin channel #160

Merged
merged 25 commits into from
Feb 12, 2020
Merged

support inference with Myelin channel #160

merged 25 commits into from
Feb 12, 2020

Conversation

xiuliren
Copy link
Member

@xiuliren xiuliren commented Feb 4, 2020

  • add setup-env operator to automatically prepare environment
  • avoid mask buffer to make memory usage more efficient
  • refactor normalize-section-contrast operator to make it faster and easier to use

…aster computation; the code complexity is also greatly reduced for easier mentainance
… inference test and move the test case to test_inferencer.py file; still have a bug of blending...
… this bug; still have bug for crop patch alignment and the tests did not pass;
…ss; add dry run option for setup-env operator; rescale the bump mask in order to keep the numerical precision since it might created the chunk boundary effect;
@xiuliren xiuliren merged commit e44e8d8 into master Feb 12, 2020
@xiuliren xiuliren deleted the myelin branch February 12, 2020 18:01
@xiuliren xiuliren changed the title Myelin support inference with Myelin channel Feb 12, 2020
@shangmu
Copy link
Contributor

shangmu commented Feb 13, 2020

The whole Image class is broken. Master branch is supposed to be a useable branch.

@xiuliren
Copy link
Member Author

hmm, will take look. thanks!

@xiuliren
Copy link
Member Author

xiuliren commented Feb 13, 2020

@shangmu could you try the fix-image branch?
#161

It would be great if you can add a few unit tests, so I'll notice the code break.

@xiuliren
Copy link
Member Author

I have merge the branch to master to fix the travis tests.

@shangmu
Copy link
Contributor

shangmu commented Feb 13, 2020

What I mean by the Image class being broken is it won't even get instantiated:

class Image(Chunk):
    def __new__(cls, array, **kwargs):
        ...
        obj = Chunk(array, global_offset=global_offset, *kwargs).view(cls)

There isn't even a Chunk.view() method anymore.

@xiuliren
Copy link
Member Author

xiuliren commented Feb 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants