Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region Graph Function #18

Closed
william-silversmith opened this issue Jun 11, 2019 · 2 comments
Closed

Region Graph Function #18

william-silversmith opened this issue Jun 11, 2019 · 2 comments
Labels
feature New feature or request

Comments

@william-silversmith
Copy link
Contributor

In #13 it was requested that we have a way to return the region graph of a labeled volume. This is a pretty good idea and is probably useful in this lab and in others.
@william-silversmith william-silversmith added the feature New feature or request label Jun 11, 2019
william-silversmith added a commit that referenced this issue Jun 13, 2019
@william-silversmith
feat: very slow region graph function
80507ad 
Per #18 and #13, and with some internet research, I found that
options are somewhat limited for deriving a region graph from
a labeled image.

Here is a very slow initial implementation (600s for a 512 cube
vs 1s for connected_components). This can be improved, but at least
there's something.
@william-silversmith william-silversmith mentioned this issue Jun 13, 2019
Merged
william-silversmith added a commit that referenced this issue Jun 13, 2019
@william-silversmith
feat: region graph function (#20)
466f307 
* feat: very slow region graph function

Per #18 and #13, and with some internet research, I found that
options are somewhat limited for deriving a region graph from
a labeled image.

Here is a very slow initial implementation (600s for a 512 cube
vs 1s for connected_components). This can be improved, but at least
there's something.

* perf: 4x faster using cdef on neighbors

* docs: add docstring to region_graph and add declaration to connected_components

* test: basic test for region_graph

* docs: mentioned region_graph function
@william-silversmith
Copy link
Contributor Author

@wenshuaizhao I added a slow but potentially useful region graph function in 1.3.0. Give it a try if you still need it. :)

@william-silversmith
Copy link
Contributor Author

It's now tested better in #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@william-silversmith