feat: support arbitrary labels #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using unordered map instead of an array is several times slower, but we can support the use of IDs that are larger than the array size. Right now, one must run renumber on arbitrary data before running cc3d. The array also takes up a lot of space. For ordinary data, the hashmap is more memory efficient. However, on the pathological case of sequence data, memory blows up. Ideally, you should be able to choose which version of union-find to use.
|
Just was thinking that using an array was always a good optimization for Wu et al because they were working with binary data only. This eliminated the complication that comes from arbitrary labels, since the first key is always 1. |
8 tasks
william-silversmith
force-pushed
the
master
branch
from
cfe3d3e
to
07d5f18
Compare
|
It does support arbitrary labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using unordered map instead of an array is several times slower,
but we can support the use of IDs that are larger than the array
size. Right now, one must run renumber on arbitrary data before
running cc3d. The array also takes up a lot of space.
For ordinary data, the hashmap is more memory efficient. However,
on the pathological case of sequence data, memory blows up.
Ideally, you should be able to choose which version of union-find
to use.