Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - specify that worker must import function in the same way as when it was inserted #37

Closed
emjoyce opened this issue Sep 14, 2021 · 4 comments
Labels
documentation Adds or modifies documentation.

Comments

@emjoyce
Copy link

emjoyce commented Sep 14, 2021

It may be helpful someone in the future to specify that functions must be imported in the same way for the worker and for insertion (readme or a special error message).

I had a function from a module of mine that I copied into a notebook to troubleshoot and edit. I added the queueable decorator right there in the notebook and used that function for my task insertion. I copied that edited function back into my module, and imported from there for the worker.

I was getting the error 'not registered as a queueable function' and could not figure out what the issue was for a while. I had to import the function from my module for the insertion as well and then it worked.

@william-silversmith
Copy link
Contributor

william-silversmith commented Sep 14, 2021 via email

@william-silversmith
Copy link
Contributor

I wonder if it might be easier to just automatically import the functions. The data payload includes both the module and function to call, so that's something we could do. I'm just wondering if doing so would cause any security concerns.

@william-silversmith
Copy link
Contributor

Yea, there would be. A compromised queue could then pull in functions that are not meant to be run. I'll stick with the warning.

@william-silversmith william-silversmith added the documentation Adds or modifies documentation. label Sep 15, 2021
@william-silversmith
Copy link
Contributor

Thanks for opening the issue! Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Adds or modifies documentation.
Projects
None yet
Development

No branches or pull requests

2 participants