Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a trigger to puma config, for support Issue #25 #26

Merged
merged 2 commits into from
Jan 28, 2014

Conversation

crhan
Copy link
Collaborator

@crhan crhan commented Jan 20, 2014

  • Remain the same config output for minor changes
  • set :puma_active_record_establish_connection, true to enable this
    feature

- Remain the same config output for minor changes
- `set :puma_active_record_establish_connection, true` to enable this
  feature
@seuros
Copy link
Owner

seuros commented Jan 21, 2014

Thank you, @crhan do you want to be a collaborator in this gem ?

@crhan
Copy link
Collaborator Author

crhan commented Jan 21, 2014

Yeah~! That would be my pleasure

- rename :puma_active_record_establish_connection to
  :puma_init_active_record
@crhan
Copy link
Collaborator Author

crhan commented Jan 28, 2014

is this the right time to release v0.2.0?

seuros added a commit that referenced this pull request Jan 28, 2014
add a trigger to puma config, for support Issue #25
@seuros seuros merged commit 326c4ae into seuros:master Jan 28, 2014
@seuros
Copy link
Owner

seuros commented Jan 28, 2014

Yes.

@crhan
Copy link
Collaborator Author

crhan commented Jan 28, 2014

hmmm. Could you tag the commit which you have released a new gem and use git push --tags to upload them?

@seuros
Copy link
Owner

seuros commented Jan 28, 2014

Yes i could. But what the aim for that?

@crhan
Copy link
Collaborator Author

crhan commented Jan 28, 2014

the main point: easy for git diff. Tag can help me diff the different from each version. that's the thing I will do on every gem update in my project.

and that will be a promise: git tag start with v(egg. v0.2.0) is a reference to the version 0.2.0 on the https://rubygems.org. You can take rails as an example

@seuros
Copy link
Owner

seuros commented Jan 28, 2014

Thanks. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants