Skip to content

Commit

Permalink
Support the storage/discovery_status tag in get_embedded_health output
Browse files Browse the repository at this point in the history
  • Loading branch information
seveas committed Nov 1, 2014
1 parent e03dcb7 commit 6804064
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions hpilo.py
Original file line number Diff line number Diff line change
Expand Up @@ -948,8 +948,12 @@ def _parse_get_embedded_health_data_firmware_information(self, element):
return {element.tag.lower(): ret}

def _parse_get_embedded_health_data_storage(self, element):
ret = []
key = element.tag.lower()
ret = {key: []}
for ctrl in element:
if ctrl.tag == 'DISCOVERY_STATUS':
ret['%s_%s' % (key, ctrl.tag.lower())] = self._element_children_to_dict(ctrl)['status']
continue
data = {}
for elt in ctrl:
tag = elt.tag.lower()
Expand All @@ -963,8 +967,8 @@ def _parse_get_embedded_health_data_storage(self, element):
data[tag].append(self._parse_logical_drive(elt))
else:
data[tag] = elt.get('VALUE')
ret.append(data)
return {element.tag.lower(): ret}
ret[key].append(data)
return ret

def _parse_logical_drive(self, element):
data = {}
Expand Down

0 comments on commit 6804064

Please sign in to comment.