Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mod_dir_config able to unset/remove values. #119

Closed
wants to merge 1 commit into from

Conversation

alxgu
Copy link
Contributor

@alxgu alxgu commented Sep 13, 2016

Bugfix Pull Request

Can't delete a value in mod_dir_config. I'm getting a "syntax error" response.

Example: hpilo_cli server1.loc mod_dir_config dir_grpacct2_sid=''

Before

for_bugreport.txt

HTTP/1.1
200 OK
Content-Type: text/xml
Transfer-Encoding: chunked
Cache-Control: no-cache
Connection: close
Date: Tue, 13 Sep 2016 12:13:34 GMT
Server: HP-iLO-Server/1.30
X-Frame-Options: sameorigin

0e8

074

107

0

XML Request

<RIBCL VERSION="2.0"><LOGIN PASSWORD="***" USER_LOGIN="user1"><DIR_INFO MODE="write"><MOD_DIR_CONFIG /></DIR_INFO></LOGIN></RIBCL>

After Bugfix

XML Request

<RIBCL VERSION="2.0"><LOGIN PASSWORD="********" USER_LOGIN="user1"><DIR_INFO MODE="write"><MOD_DIR_CONFIG><DIR_GRPACCT2_SID VALUE="" /></MOD_DIR_CONFIG></DIR_INFO></LOGIN></RIBCL>
...

my_ilo.mod_dir_config(dir_grpacct2_sid="")

Example: hpilo_cli server1.loc mod_dir_config dir_grpacct2_sid=''
@seveas
Copy link
Owner

seveas commented Sep 13, 2016

Thanks! I wonder if the same bug is present in other functions as well. Did you check?

@alxgu
Copy link
Contributor Author

alxgu commented Sep 13, 2016

Yes, this kind of value check is only in mod_dir_config

@seveas
Copy link
Owner

seveas commented Sep 13, 2016

Great, thanks! I'll merge this later today and add a test for this.

@seveas
Copy link
Owner

seveas commented Oct 27, 2016

Now cherry-picked, and test added.

@seveas seveas closed this Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants