Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request url for book with number #22

Open
stefanauwyang opened this issue Jun 17, 2017 · 2 comments
Open

Request url for book with number #22

stefanauwyang opened this issue Jun 17, 2017 · 2 comments

Comments

@stefanauwyang
Copy link

On top of '1 chronicles' and '2 chronicles' as input, may be can consider to add 'first chronicles' and 'second chronicles'. Also for the rest of the multiple books. Thanks :)

@meichthys
Copy link

I also have a use case for this - although i can easily work around it, so it's not necessary.
meichthys/sword_drill#5

@johndoesniper
Copy link

On top of '1 chronicles' and '2 chronicles' as input, may be can consider to add 'first chronicles' and 'second chronicles'. Also for the rest of the multiple books. Thanks :)

I would recommend processing your input before making the request. You're reducing complexity for @seven1m, alleviating processing on the API/server, reducing overhead during transport and it isn't as costly to process it on your input. I had a similar use case and decided to address it with an array of all the books and included possible variations (i.e. array is greater than the 66 books). The added benefit is you can also handle future (language) translations should you take on the enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants