Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exodus 1:1 kjv has a newline in the middle of it #32

Open
Zachiah opened this issue Feb 21, 2020 · 5 comments
Open

Exodus 1:1 kjv has a newline in the middle of it #32

Zachiah opened this issue Feb 21, 2020 · 5 comments
Labels

Comments

@Zachiah
Copy link

Zachiah commented Feb 21, 2020

go to
http://bible-api.com/Exodus+1:1?translation=kjv and it has a random newline in the middle

@seven1m
Copy link
Owner

seven1m commented Feb 21, 2020

I'd noticed that before; it comes from the source material which is in the file eng-kjv.osis.xml here: https://github.com/seven1m/open-bibles/

<verse osisID="Exod.1.1" sID="Exod.1.1.seID.01585" n="1" />Now these
<transChange type="added">are</transChange> the names of the children of Israel, which came into Egypt; every man and his household came with Jacob.

I think it would be safe to strip newlines from the XML during parsing. I'll see about doing that.

Thanks for the bug report!

@Zachiah
Copy link
Author

Zachiah commented Feb 25, 2020

Thank you
you might be able to just replace all whitespace with a space because john 3:16 kjv for example also starts with a margin

@Zachiah
Copy link
Author

Zachiah commented Feb 25, 2020

for now I'll just use
text.strip.gsub("\n"," ")
in my rails app

@seven1m
Copy link
Owner

seven1m commented Jul 20, 2020

Extra examples:

  • Revelation 22:21
  • John 3:16

@abbasou
Copy link

abbasou commented May 9, 2024

Coming back to this as I've found many, many examples of this in the KJV. Attempting to use Obsidian Bible Reference plugin, but output formatting is almost unusable. Will open issue over there to see if there is a fix post-api call, but would be nice to fix it on the source side I would think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants