Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar #75

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add progress bar #75

wants to merge 1 commit into from

Conversation

realjanpaulus
Copy link
Collaborator

@realjanpaulus realjanpaulus commented Jul 29, 2022

Closes #68.
Draft PR.

@realjanpaulus realjanpaulus added the enhancement New feature or request label Jul 29, 2022
@realjanpaulus realjanpaulus self-assigned this Jul 29, 2022
@@ -8,6 +8,7 @@ build = "build.py"

[tool.poetry.dependencies]
python = "^3.9"
progress = "^1.6"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't want any third-party dependencies. Since progress is a quite lightweight project, can you just migrate to chaine? As a submodule?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A refactoring of progress is necessary in the first place, because we don't need all these different stylings of the progress bar:

68747470733a2f2f7261772e6769746875622e636f6d2f7665726967616b2f70726f67726573732f6d61737465722f64656d6f2e676966

Just a single, simple and plain progress bar.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the Bar one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer the Bar one, the integration of progress is currently temporary and for testing purposes. The main reason for this very drafty PR is, that I'm continue to work on this PR on another computer.

I'm currently not sure if I will integrate this directly into the C code or as an outer layer within the Python code, but I would prefer the first one to have more control over the bar.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar
2 participants