Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Input #6

Closed
seyedali-dev opened this issue May 11, 2024 · 0 comments · Fixed by #24
Closed

Validate Input #6

seyedali-dev opened this issue May 11, 2024 · 0 comments · Fixed by #24
Assignees
@seyedali-dev
Labels
bug Something isn't working enhancement Enhance a feature testing Implement testing

Comments

@seyedali-dev
Copy link
Owner

The input that the user enters, must be validated.
Specifically, it'll be a bit challenging for start_time & end_time which are an Instant fields.
@seyedali-dev seyedali-dev added bug Something isn't working enhancement Enhance a feature testing Implement testing labels May 11, 2024
@seyedali-dev seyedali-dev self-assigned this May 11, 2024
seyedali-dev added a commit that referenced this issue May 16, 2024
@seyedali-dev
feature: Implemented bean validation. (Close #6)
e0cbf02 
Implemented bean validation for `TimeEntryDTO` & `TimeBillingDTO`
@seyedali-dev seyedali-dev mentioned this issue May 16, 2024
Merged
seyedali-dev added a commit that referenced this issue May 17, 2024
@seyedali-dev
bug: Modified tests for bean validation. (WIP) (Close #6)
a3d44a1 
Implemented bean validation for `TimeEntryDTO` & `TimeBillingDTO`.

> Note: The tests are passing because we're providing null values for `TimeEntryDTO#hourlyRate`, whereas we should write tests for both scenarios.
seyedali-dev added a commit that referenced this issue May 17, 2024
@seyedali-dev
Merge pull request #24 from sayedxali/feature/input-validation
25da9dd 
Feature/input validation - Close #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seyedali-dev seyedali-dev

Labels
bug Something isn't working enhancement Enhance a feature testing Implement testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/input validation - Close #6 seyedali-dev/DevClock-v0.1_TimeEntryService
1 participant
@seyedali-dev