Don't load STM samples with volume=0, fix sample offset calculation. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* STM samples with zero volume are now treated as having zero length and are now ignored entirely. * STM sample offsets are now calculated with [reserved byte]<<4. This replaces the MikMod_ISA variable that was being used to work around some instances of the zero volume samples bug. * STM samples that break file bounds will be truncated or result in the file being rejected altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various edge-case bugs that affect a handful of .STM files. This is the same patch I posted before but, aside from minor details like setting seekpos=0, I'm fairly confident this patch is correct/ready for PR.
Fixes #6.