Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen flashes are broken on some maps #42

Closed
Flecked42 opened this issue Oct 10, 2022 · 22 comments
Closed

Screen flashes are broken on some maps #42

Flecked42 opened this issue Oct 10, 2022 · 22 comments

Comments

@Flecked42
Copy link

Flecked42 commented Oct 10, 2022

Screen flashes get broken on some maps.

The map in the video is ctsj2_bal from Coppertone Summer Jam 2 pack https://www.quaddicted.com/filebase/ctsj2_1.2.zip
It happens in other maps as well, strange bug.

QS_flashes.mp4

This also happens in QSS, but it doesn't happen in Ironwail or vkQuake.

@sezero
Copy link
Owner

sezero commented Oct 10, 2022

I really have no idea about this. @andrei-drexler? (Since the op said it doesn't happen in ironwail..)

@Flecked42
Copy link
Author

Flecked42 commented Oct 10, 2022

Seems to have something to do with the skybox.

Type sky "" in the console to remove the skybox and the issue goes away.

@Flecked42
Copy link
Author

Also this issue doesn't happen with 0.94.7

@sezero
Copy link
Owner

sezero commented Oct 10, 2022

Also this issue doesn't happen with 0.94.7

Now that's noteworthy. The lit water patch was the only thing that would affect such a thing??

@sezero
Copy link
Owner

sezero commented Oct 11, 2022

CC: @ericwa, @temx

@ericwa
Copy link
Contributor

ericwa commented Oct 11, 2022

I'm not having any luck reproducing this. Here is what my configuration looks like:

@Flecked42 can you give details on your system configuration, or see if you spot any differences vs what I tried?

@ericwa
Copy link
Contributor

ericwa commented Oct 11, 2022

Seems to have something to do with the skybox.

Type sky "" in the console to remove the skybox and the issue goes away.

There is also this console warning, might be related:

Warning: Sky texture skybal is 128 x 128, expected 256 x 128

@Flecked42
Copy link
Author

@ericwa I have an AMD card, RX 580, using latest drivers 22.10.1

Maybe an AMD only issue?

@Flecked42
Copy link
Author

Flecked42 commented Oct 11, 2022

The lit water patch was the only thing that would affect such a thing??

Ah changing r_litwater to 0 seems to make the issue go away.
But still strange that removing the skybox also makes the issue go away.

I'm guessing its the new AMD drivers since litwater alpha in JoeQuake also broke from them.
j0zzz/JoeQuake#61

@Flecked42
Copy link
Author

Here's a video that shows the issue in more detail

https://streamable.com/so4p9a

@Flecked42
Copy link
Author

Flecked42 commented Oct 11, 2022

Also this issue doesn't happen with 0.94.7

I take that back. Noticed there's an issue in 0.94.7 also. I guess this is the same issue as in 0.95.0 with litwater off.

These issues are most certainly from AMDs new drivers.

QS_water.mp4

@sezero
Copy link
Owner

sezero commented Oct 11, 2022

Close the ticket then?

@Flecked42
Copy link
Author

Flecked42 commented Oct 11, 2022

Guess that's up to you, but i don't think AMD is gonna fix issues in a Quake sourceport.

Ironwail and vkQuake don't have the issues though, so i dunno.

@sezero
Copy link
Owner

sezero commented Oct 11, 2022

@ericwa, @andrei-drexler: Do we have a workaround for this??

@Flecked42
Copy link
Author

The issues go away when using -noglsl in the command line, maybe will help.

@temx
Copy link
Contributor

temx commented Oct 13, 2022

Here's a (hopefully zero-cost) workaround: amd-polyblend-workaround.txt

@sezero
Copy link
Owner

sezero commented Oct 13, 2022

Here's a (hopefully zero-cost) workaround: amd-polyblend-workaround.txt

Huh.. Move glColor4fv between glBegin and glEnd, which is actually legal
according to the man page.

Thanks, will apply shortly.

sezero added a commit that referenced this issue Oct 13, 2022
which is legal by GL spec. Fixes screen flashes in some maps with AMD's
new drivers.  Patch authored by temx (@temx at github.)
Reference issue: #42.
@sezero
Copy link
Owner

sezero commented Oct 13, 2022

OK, should be fixed as of f09b26b, closing.

If you can't build yourself and need win32 or win64 binaries, tell me.

@sezero sezero closed this as completed Oct 13, 2022
@Flecked42
Copy link
Author

Flecked42 commented Oct 13, 2022

Not a big deal for me as i use JoeQuake, but if you want me to test it, i would need win64 binaries.

@sezero
Copy link
Owner

sezero commented Oct 13, 2022

but if you want me to test it, i would need win64 binaries.

Testing would be nice. Here are win64 builds from git master: qs-w64.zip

@Flecked42
Copy link
Author

Looks good, fixed on my end.

@sezero
Copy link
Owner

sezero commented Oct 13, 2022

Looks good, fixed on my end.

Thanks for testing.

alexey-lysiuk pushed a commit to alexey-lysiuk/quakespasm-exp that referenced this issue Oct 24, 2022
which is legal by GL spec. Fixes screen flashes in some maps with AMD's
new drivers.  Patch authored by temx (@temx at github.)
Reference issue: sezero/quakespasm#42.

(cherry picked from commit f09b26b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants