Fix early error

[kentcdodds]

We used to have a nice error message when you entered a script name that didn't exist. We seem to have broken that and now we see:

~/Developer/glamorous (pr/with-theme)
🐿  $ nps blah
TypeError: Cannot read property 'scriptName' of undefined
    at runPackageScript (/Users/kdodds/Developer/glamorous/node_modules/nps/dist/index.js:95:35)
    at /Users/kdodds/Developer/glamorous/node_modules/nps/dist/index.js:77:14
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:169:7)
    at Function.Module.runMain (module.js:607:11)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3

This seems to be coming from this. We should probably just add || {} to the end of that line. We should also have a unit test for this.

Should be pretty straightforward. Any takers?

[imbhargav5]

I faced this issue when I was trying to commit the first time as well. I wanted to add myself as a contributor and then make my first PR, but that din't happen. So had to do it without adding myself. I was debugging it, thought maybe I was doing something wrong. I will have a look at this one.

Does the "lint-staged" task for contributors work now ? I seem to be getting this error all the time.

Edit Never mind. The error on my end was because I was using "fish" shell and it doesn't support && in commands.

I will take up this issue nevertheless.

[kentcdodds]

Oh thanks! I didn't realize that fish doesn't support &&... Hmmm... Maybe that's something we can handle in the nps-utils series util... 🤔

[imbhargav5]

Yes! I was surprised that it doesn't. And the issue is in "will-not-implement" milestone. 😅 So perhaps we should find a way to not use "&&" and use "series" as you mentioned. Here you go.
Issue in fish shell

[kentcdodds]

Yeah, if there's a way for us to detect that you're using fish (I'll bet there's an npm package that'll tell you the current shell) then we could use that in series to determine whether to use && or something else.