New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support YAML config #63
Comments
I'd be ok with that. Mind filing a PR? |
I can try, but not this week |
Sounds good to me. Let me know if you need a hand. |
I may have time to look into it this week too, if needed. 😄 |
I'm sure that @bfred-it would appreciate it :) It's unlikely that I'll work on this. |
* feat(cli): add .yml config support Allow configuring nps in `package-scripts.yml` instead of `package-scripts.js` issue: #63 * feat(cli): fix some failing tests fix some of the tests broken along with YAML support issue: #63 * feat(cli): reduce cyclomatic complexity of getPSConfig reduce cyclomatic complexity of getPSConfig issue: #63 * feat(cli): change precedence of .yml and .js configs change precedence of `package-scripts.yml` and `package-scripts.js` so that if a .js file is present it will be used over the .yml one issue: #63 * feat(cli): remove `package-scripts.yml` remove `package-scripts.yml` close issue: #63
Looks great! I was wonder though why that extra |
Yeah, it's so you can specify |
Duh! Didn't even notice that. Thanks! |
Yeah, sorry for doing that without asking! Initially I implemented it without the scripts level, but that felt a bit off, i.e. that it would have forced potential YAML fans to still go with the JS version due to the former being (artificially) limited. :) As a side note: would it make sense to make it so that the |
Oh yeah, great idea! Feel free to file an issue for that 👍 |
It'd be nice if p-s supported YAML configuration alongside the JS one
CommonJS files are slightly easier to read/write than JSON, but JS objects are still full
'{"\,}
in YAML it would just be
Plus, even the syntax highlighter is nicer to YAML :P
YAML isn't dynamic like JS, but probably most people don't use that (and if they do, they can just use the standard CJS syntax)
The text was updated successfully, but these errors were encountered: