Utils documentation fix #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 376 376
Branches 90 90
=====================================
Hits 376 376Continue to review full report at Codecov.
|
kentcdodds
pushed a commit
that referenced
this pull request
Nov 9, 2017
* WIP: Help Style configuration to eliminate excessively long help output * WIP: trying to solve these testing issues * WIP: tests passing but missing cli flags * WIP: added tests for CLI flags * WIP: change help-style alias to 'y' to maintain single char flag/dash pattern * docs: Utils documentation fix (#163) * Update concurrently => concurrent in examples * Add myself as a contributer * Add myself as a contributer properly, this time :) * wIP: started on readme docs * WIP: updated a couple files based on feedback in the pull request * WIP: added myself as a contributor * WIP: moved help-style defaults to function calls * WIP: added check for undefined to helpstyle, almost 100% code coverage * feat: implemented configuration options for Help Style * fix: making sure tests/validations run properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Changing the use of
concurrentlyin the examples toconcurrent, so that it matches the documentation innps-utils.Why: Copying and pasting the example from the documentation throws an error since
concurrentlyis undefined.Checklist: