Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug in PR#181 and adds a test. #183

Merged
merged 2 commits into from
Jun 23, 2018

Conversation

Hypercubed
Copy link
Contributor

Sorry for the bad PR, this fixes the bug I introduced and adds a test. Still not getting 100% coverage, unfortunately.

@Hypercubed
Copy link
Contributor Author

I tried to get 100% coverage but I'm not familiar with the mocking setup.

@kentcdodds
Copy link
Collaborator

I'm fine if you want to add an /* istanbul ignore next */ comment where the coverage issue is.

@Hypercubed
Copy link
Contributor Author

Will do...

@codecov
Copy link

codecov bot commented Jun 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@e52b136). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #183   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     12           
  Lines             ?    386           
  Branches          ?     93           
=======================================
  Hits              ?    386           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/bin-utils/initialize/index.js 100% <ø> (ø)
src/bin-utils/parser.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52b136...e727bf9. Read the comment docs.

@kentcdodds kentcdodds merged commit ddca423 into sezna:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants