Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging and silent #195

Merged
merged 4 commits into from
Mar 10, 2019
Merged

Fix logging and silent #195

merged 4 commits into from
Mar 10, 2019

Conversation

kevjin
Copy link
Collaborator

@kevjin kevjin commented Mar 10, 2019

What: This PR resolves #141 . Fixes configurable options for logging levels and silent.

Why: CLI default log level and silent options ('info' and false) override custom options configured in package-scripts.

How: Swap the order in which lodash merges default and config options.

Checklist:

  • Documentation N/A
  • [ X] Tests
  • [X ] Ready to be merged
  • [X ] Added myself to contributors table

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #195   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         389    389           
  Branches       94     94           
=====================================
  Hits          389    389

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d3b73...734310a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #195   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         389    389           
  Branches       94     94           
=====================================
  Hits          389    389

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d3b73...734310a. Read the comment docs.

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thank you :)

@kentcdodds kentcdodds merged commit a0c961a into sezna:master Mar 10, 2019
@kentcdodds
Copy link
Collaborator

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@kevjin kevjin deleted the fix-logging-and-silent branch March 10, 2019 15:52
@kevjin
Copy link
Collaborator Author

kevjin commented Mar 10, 2019

Thanks Kent, and appreciate the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

silent and logLevel option
2 participants