fix(cli): re-enable parallel scripts #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
force-pushed
the
pr/fix-parallel
branch
from
c7e5767
to
85fe58f
Compare
| @@ -15,7 +15,7 @@ before_install: | |||
| before_script: | |||
| - npm prune | |||
| script: | |||
| - npm start validate | |||
| - npm run localstart validate | |||
There was a problem hiding this comment.
This is temporary. Because p-s uses itself, it is also broken by the thing this PR is fixing.
|
|
kentcdodds
force-pushed
the
pr/fix-parallel
branch
from
85fe58f
to
9e982a8
Compare
Current coverage is 100%
|
kentcdodds
force-pushed
the
pr/fix-parallel
branch
2 times, most recently
from
88193c4
to
453ba52
Compare
| @@ -82,6 +82,10 @@ | |||
| "lcov", | |||
| "text", | |||
| "html" | |||
| ], | |||
| "exclude": [ | |||
There was a problem hiding this comment.
This stuff is actually in master right now, not sure why it's still showing up in this PR. Ignore it :-)
kentcdodds
force-pushed
the
pr/fix-parallel
branch
from
453ba52
to
da6f1ab
Compare
|
Ok, I'm pretty certain this'll work now :-) |
PR #29 broke the following case: ``` p-s -p lint,test ``` This commit fixes it by getting the scripts from the args first and seeing if there are any scripts available to run. If not, then we show the help message.
kentcdodds
force-pushed
the
pr/fix-parallel
branch
from
da6f1ab
to
27e2843
Compare
|
Sweet! The build is finally green! Pinging again: @giladgo, @abhishekisnot, @rowanoulton, @tleunen, @jisaacks, @nkbt Could one of you review this and merge if it looks good? |
|
LGTM ;) |
|
Nice. |
|
Thanks for the update @nkbt! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes an issue with parallel scripts
Why:
PR #29 broke the following case:
How:
This commit fixes it by getting the scripts from the args first and seeing if there are any scripts available to run. If not, then we show the help message.
CC: @giladgo, @abhishekisnot, @rowanoulton, @tleunen, @jisaacks, @nkbt
Could one of you give this the green light and press the green button please?