GCC 6.3 warning - throwing an exception from noexcept method #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error will be logged instead of throwing an exception from noexcept method Statement::close() and program will be terminated by calling std::terminate directly. It's fixed because is not intended to throw messages directly from methods with noexcept specifier and this is also checked by compilers with -Wall option by default.
smradCZ
force-pushed
the
gcc_6_3_compile_error
branch
from
4b2ff06
to
12a008f
Compare
majcl
suggested changes
Dec 6, 2017
include/superior_mysqlpp/logging.hpp
Outdated
| @@ -703,7 +711,7 @@ namespace SuperiorMySqlpp { | |||
| } | |||
|
|
|||
| public: | |||
| static bool isDestoyed() | |||
| static bool isDestroyed() | |||
There was a problem hiding this comment.
This is kind of unrelated change. Please put it into another pull request.
Also, this is unfortunately interface change and thus this should implicate library major version update. Though, for now, we still have major version 0 - so this probably is not necessary.
Anyway, my first request stands. Please put this into another pull request.
packages/_debian-common/changelog
Outdated
| @@ -2,6 +2,7 @@ libsuperiormysqlpp (0.3.1) UNRELEASED; urgency=medium | |||
|
|
|||
| [ Radek Smejdir ] | |||
| * Fix ostream operator for null values in Row | |||
| * noexcept Statement.close() will not throw MysqlInternalError anymore | |||
There was a problem hiding this comment.
Please mention also, that instead log function will be called and std::terminate will be called.
smradCZ
force-pushed
the
gcc_6_3_compile_error
branch
from
12a008f
to
8c2bf1a
Compare
majcl
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error will be logged instead of throwing an exception from noexcept
method Statement::close() and program will be terminated by
calling std::terminate directly.
It's fixed because is not intended to throw messages directly from
methods with noexcept specifier and this is also checked by compilers
with -Wall option by default.
It fixes #41 also.
This is one step from many in process of porting package to debian-stretch.